Skip to content

Follow-up from "Block recursive web hooks"

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

The following discussion from !79085 (merged) should be addressed:

  • @toupeira started a discussion: (+1 comment)

    thought (non-blocking): I'm not sure if it makes sense to log again if we already did so in async_execute 🤔 I guess it's possible that a webhook becomes blocked after it was already queued, in which case I think we do want this second log message (otherwise we wouldn't have any indication at all). So I think we should keep this 👍

    I also notice the other blocks behave slightly differently:

    • Rate-limits are only checked and logged when queueing, but not when executing.
    • WebHook#executable? is checked both when queueing and executing, but never logged.

    I wonder if we can align these a bit, but on the other hand each block has slightly different requirements so some of the differences are probably justified.

Edited by 🤖 GitLab Bot 🤖