Typo in error message on issue belonging to confidential epic
Summary
Error message on an issue that belongs to a confidential epic displays as:
Issue this issue cannot be made public since it belongs to a confidential epic
Steps to reproduce
- Add an epic and set to Confidential.
- Add an issue in the epic and set to Confidential.
- Turn off Confidentiality.
- The following message is displayed:
Issue this issue cannot be made public since it belongs to a confidential epic
The expected message is:
This issue cannot be made public since it belongs to a confidential epic
Discovered by @bbodenmiller in discussion with @dianalogan on this confidential issue: https://gitlab.com/gitlab-org/gitlab/-/issues/227858#note_807262547.
Example Project
Screenshot comes from https://gitlab.com/gitlab-org/gitlab/-/issues/350058
What is the current bug behavior?
See Steps to reproduce.
What is the expected correct behavior?
See Steps to reproduce.
Relevant logs and/or screenshots
@rdickenson has started looking at this:
The following phrase is contained in file https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/app/models/ee/issue.rb#L280:
this issue cannot be made public since it belongs to a confidential epic
The question now is: where is the Issue prefix coming from? That must be being added in another part of the code base.