Imports fail in 14.5.2 fail with HTTParty::UnsupportedURIScheme error
Summary
Smart client validation in !70165 (merged) breaks imports from minimalist Git servers
Steps to reproduce
- Pick a gitdaemon publishing repositories via git:// protocol (NOT HTTP)
- Import a published repository via API
What is the current bug behavior?
- Import via Web GUI: Works, but
HTTParty::UnsupportedURIScheme: 'git://<GIT_SERVER_URL>/info/refs?service=git-upload-pack' Must be HTTP, HTTPS or Genericerror thrown in the logs - via ReST API: Will fail immediately with
HTTParty::UnsupportedURIScheme: 'git://<GIT_SERVER_URL>/info/refs?service=git-upload-pack' Must be HTTP, HTTPS or Genericerror
What is the expected correct behavior?
- Import should work via API with git URL
Relevant logs and/or screenshots
Output of checks
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:env:info`) (For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)(we will only investigate if the tests are passing)
Possible fixes
Edited by Rocky Mongare