GraphQL Todo Query returns wrong IDs

Summary

As mentioned and fixed before in !18581 (merged) the global IDs for todos within the response of graphql todo query is wrong. It contains TodoPresenter\id instead of Todo\id.

Steps to reproduce

Using GraphiQL:

{
  currentUser {
    todos {
      nodes {
        id
      }
    }
  }
}

Results in:

{
  "data": {
    "currentUser": {
      "todos": {
        "nodes": [
          {
            "id": "gid://gitlab/TodoPresenter/259"
          },
          {
            "id": "gid://gitlab/TodoPresenter/253"
          }
        ]
      }
    }
  }
}

But should instead look like this:

{
  "data": {
    "currentUser": {
      "todos": {
        "nodes": [
          {
            "id": "gid://gitlab/Todo/259"
          },
          {
            "id": "gid://gitlab/Todo/253"
          }
        ]
      }
    }
  }
}

Example Project

What is the current bug behavior?

Wrong IDs are returned for todos in graphql.

What is the expected correct behavior?

Correct global ids should be returned.

Relevant logs and/or screenshots

Output of checks

This bug happens on GitLab.com

Results of GitLab environment info

Results of GitLab application Check

Possible fixes

Edited Oct 24, 2019 by Patrick Derichs
Assignee Loading
Time tracking Loading