Add Rubocop to check for SSL verification setting on integrations
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
Background
The following discussion from https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/2043 should be addressed:
-
@alexkalderimis started a discussion: I understand why this is not part of
BaseCI(for services likeBuildKite) - but I feel we want assurance that new services get this as well.Can we perhaps add a rubocop rule such that:
- for all CI integrations (only CI integrations?)
- the class must prepend
EnableSslVerification
optional: only if a URL is declared
This should be a follow-up
This would make sense for all integrations which can be self-hosted (e.g. Jira), not just CI integrations.
Edited by 🤖 GitLab Bot 🤖