Delete container registry tag: Undefined method `success?' for nil

Summary

Running Omnibus on Ubuntu 18.04. Recently upgraded one minor version at a time from 11.10 to 12.4

On Version 12.4.0:

https://gitlab.example.com/name/project/container_registry

Clicking delete tag shows Something went wrong on our end.

I tried gitlab-ctl restart and logging out and back in to refresh the session.

What is the current bug behavior?

NoMethodError while trying to delete

What is the expected correct behavior?

The image is deleted

Relevant logs and/or screenshots

curl 'https://gitlab.example.com/name/project/registry/repository/5/tags/9-new-site-www-example-com' -X DELETE -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:69.0) Gecko/20100101 Firefox/69.0' -H 'Accept: application/json, text/plain, */*' -H 'Accept-Language: en-US,en;q=0.5' --compressed -H 'Referer: https://gitlab.example.com/name/project/container_registry' -H 'X-CSRF-Token: xxx' -H 'X-Requested-With: XMLHttpRequest' -H 'Connection: keep-alive' -H 'Cookie: sidebar_collapsed=false; pipeline_schedules_callout_dismissed=true; experimentation_subject_id=xxx; _gitlab_session=xxx; event_filter=all'

Completed 500 Internal Server Error in 30ms (ActiveRecord: 1.1ms | Elasticsearch: 0.0ms)

NoMethodError (undefined method `success?' for nil:NilClass):

lib/container_registry/client.rb:47:in `upload_raw_blob'
lib/container_registry/client.rb:69:in `generate_empty_manifest'
app/services/projects/container_repository/delete_tags_service.rb:38:in `smart_delete'
app/services/projects/container_repository/delete_tags_service.rb:13:in `execute'
app/controllers/projects/registry/tags_controller.rb:25:in `destroy'
lib/gitlab/session.rb:11:in `with_session'
app/controllers/application_controller.rb:461:in `set_session_storage'
lib/gitlab/i18n.rb:55:in `with_locale'
lib/gitlab/i18n.rb:61:in `with_user_locale'
app/controllers/application_controller.rb:455:in `set_locale'
lib/gitlab/request_profiler/middleware.rb:17:in `call'
lib/gitlab/middleware/go.rb:20:in `call'
lib/gitlab/etag_caching/middleware.rb:13:in `call'
lib/gitlab/middleware/correlation_id.rb:16:in `block in call'
lib/gitlab/middleware/correlation_id.rb:15:in `call'
lib/gitlab/middleware/multipart.rb:117:in `call'
lib/gitlab/middleware/read_only/controller.rb:48:in `call'
lib/gitlab/middleware/read_only.rb:18:in `call'
lib/gitlab/middleware/basic_health_check.rb:25:in `call'
lib/gitlab/request_context.rb:32:in `call'
lib/gitlab/metrics/requests_rack_middleware.rb:49:in `call'
lib/gitlab/middleware/release_env.rb:12:in `call'

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info

root@git:~# gitlab-rake gitlab:env:info
System information
System:		Ubuntu 18.04
Current User:	git
Using RVM:	no
Ruby Version:	2.6.3p62
Gem Version:	2.7.9
Bundler Version:1.17.3
Rake Version:	12.3.3
Redis Version:	3.2.12
Git Version:	2.22.0
Sidekiq Version:5.2.7
Go Version:	unknown
GitLab information
Version:	12.4.0
Revision:	1425a56c75b
Directory:	/opt/gitlab/embedded/service/gitlab-rails
DB Adapter:	PostgreSQL
DB Version:	10.9
URL:		https://git.thegeck.com
HTTP Clone URL:	https://git.thegeck.com/some-group/some-project.git
SSH Clone URL:	git@git.thegeck.com:some-group/some-project.git
Using LDAP:	no
Using Omniauth:	yes
Omniauth Providers: google_oauth2
GitLab Shell
Version:	10.2.0
Repository storage paths:

• default: /var/opt/gitlab/git-data/repositories GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell Git: /opt/gitlab/embedded/bin/git

Results of GitLab application Check

gitlab-rake gitlab:check SANITIZE=true: All green. Expand for output related to the GitLab application check

root@git:~# gitlab-rake gitlab:check SANITIZE=true
Checking GitLab subtasks ...
Checking GitLab Shell ...
GitLab Shell: ... GitLab Shell version >= 10.2.0 ? ... OK (10.2.0)
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Internal API available: OK
Redis available via internal API: OK
gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Gitaly ...
Gitaly: ... default ... OK
Checking Gitaly ... Finished
Checking Sidekiq ...
Sidekiq: ... Running? ... yes
Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Incoming Email ...
Incoming Email: ... Checking Reply by email ...
IMAP server credentials are correct? ... yes
Init.d configured correctly? ... skipped
MailRoom running? ... skipped
Checking Reply by email ... Finished
Checking Incoming Email ... Finished
Checking LDAP ...
LDAP: ... LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab App ...
Git configured correctly? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... yes
Uploads directory tmp has correct permissions? ... yes
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
Projects have namespace: ...
4/3 ... yes
6/4 ... yes
7/6 ... yes
7/7 ... yes
7/8 ... yes
7/9 ... yes
7/10 ... yes
8/11 ... yes
9/13 ... yes
2/18 ... yes
8/19 ... yes
8/20 ... yes
10/22 ... yes
6/23 ... yes
2/24 ... yes
2/26 ... yes
2/27 ... yes
2/28 ... yes
12/29 ... yes
8/30 ... yes
8/31 ... yes
8/32 ... yes
5/33 ... yes
7/35 ... yes
7/36 ... yes
15/39 ... yes
8/40 ... yes
8/41 ... yes
6/43 ... yes
15/44 ... yes
15/46 ... yes
2/48 ... yes
8/49 ... yes
15/52 ... yes
2/54 ... yes
12/57 ... yes
2/58 ... yes
8/59 ... yes
18/61 ... yes
18/62 ... yes
18/63 ... yes
18/64 ... yes
18/65 ... yes
12/66 ... yes
18/67 ... yes
12/68 ... yes
12/69 ... yes
12/70 ... yes
12/71 ... yes
12/72 ... yes
47/73 ... yes
15/74 ... yes
6/75 ... yes
6/76 ... yes
8/77 ... yes
6/78 ... yes
4/80 ... yes
8/83 ... yes
19/91 ... yes
22/92 ... yes
4/93 ... yes
6/94 ... yes
6/95 ... yes
2/97 ... yes
8/106 ... yes
20/112 ... yes
8/113 ... yes
12/115 ... yes
6/117 ... yes
8/118 ... yes
8/119 ... yes
13/121 ... yes
6/123 ... yes
8/124 ... yes
6/125 ... yes
8/127 ... yes
21/128 ... yes
15/129 ... yes
8/130 ... yes
2/132 ... yes
2/133 ... yes
2/137 ... yes
15/138 ... yes
8/141 ... yes
4/144 ... yes
2/145 ... yes
4/146 ... yes
4/148 ... yes
8/149 ... yes
4/152 ... yes
18/153 ... yes
4/157 ... yes
4/158 ... yes
2/159 ... yes
12/160 ... yes
12/161 ... yes
12/162 ... yes
8/165 ... yes
4/166 ... yes
8/168 ... yes
15/169 ... yes
2/170 ... yes
2/172 ... yes
12/173 ... yes
2/176 ... yes
25/177 ... yes
8/178 ... yes
26/180 ... yes
26/181 ... yes
15/182 ... yes
25/185 ... yes
28/186 ... yes
8/187 ... yes
29/190 ... yes
8/191 ... yes
28/192 ... yes
6/193 ... yes
33/195 ... yes
2/196 ... yes
28/198 ... yes
2/201 ... yes
2/202 ... yes
8/203 ... yes
2/204 ... yes
30/205 ... yes
6/207 ... yes
8/208 ... yes
31/209 ... yes
8/210 ... yes
12/211 ... yes
2/212 ... yes
2/213 ... yes
2/214 ... yes
6/216 ... yes
32/217 ... yes
2/218 ... yes
25/219 ... yes
2/221 ... yes
6/222 ... yes
33/223 ... yes
15/224 ... yes
2/225 ... yes
32/226 ... yes
33/227 ... yes
8/228 ... yes
33/229 ... yes
6/230 ... yes
33/231 ... yes
33/232 ... yes
33/233 ... yes
18/234 ... yes
8/235 ... yes
12/236 ... yes
6/237 ... yes
25/238 ... yes
8/241 ... yes
8/242 ... yes
12/246 ... yes
8/247 ... yes
8/248 ... yes
8/249 ... yes
36/250 ... yes
2/251 ... yes
2/252 ... yes
8/253 ... yes
25/254 ... yes
2/256 ... yes
41/257 ... yes
42/260 ... yes
42/261 ... yes
13/262 ... yes
8/263 ... yes
33/265 ... yes
12/266 ... yes
4/268 ... yes
2/269 ... yes
4/270 ... yes
42/271 ... yes
4/272 ... yes
2/273 ... yes
4/276 ... yes
6/277 ... yes
2/278 ... yes
33/279 ... yes
13/281 ... yes
2/282 ... yes
15/286 ... yes
8/287 ... yes
2/288 ... yes
8/289 ... yes
13/290 ... yes
8/291 ... yes
2/292 ... yes
45/293 ... yes
46/294 ... yes
15/295 ... yes
18/296 ... yes
6/297 ... yes
36/298 ... yes
13/300 ... yes
4/301 ... yes
20/302 ... yes
25/305 ... yes
13/306 ... yes
12/307 ... yes
36/308 ... yes
2/309 ... yes
2/310 ... yes
29/311 ... yes
13/312 ... yes
41/313 ... yes
47/314 ... yes
13/316 ... yes
2/317 ... yes
2/318 ... yes
2/319 ... yes
25/320 ... yes
36/321 ... yes
2/322 ... yes
36/323 ... yes
36/324 ... yes
4/325 ... yes
2/326 ... yes
8/327 ... yes
2/331 ... yes
36/333 ... yes
11/334 ... yes
49/335 ... yes
12/336 ... yes
4/338 ... yes
8/339 ... yes
4/341 ... yes
2/342 ... yes
4/343 ... yes
4/344 ... yes
6/345 ... yes
4/346 ... yes
2/347 ... yes
2/348 ... yes
4/350 ... yes
4/351 ... yes
51/352 ... yes
6/353 ... yes
4/354 ... yes
51/355 ... yes
51/356 ... yes
51/357 ... yes
2/358 ... yes
2/360 ... yes
15/361 ... yes
4/362 ... yes
56/363 ... yes
2/364 ... yes
2/365 ... yes
20/367 ... yes
18/368 ... yes
18/369 ... yes
2/370 ... yes
8/371 ... yes
4/372 ... yes
18/373 ... yes
6/374 ... yes
8/375 ... yes
4/376 ... yes
63/377 ... yes
7/378 ... yes
2/379 ... yes
22/380 ... yes
4/381 ... yes
33/382 ... yes
18/383 ... yes
4/384 ... yes
2/385 ... yes
18/386 ... yes
2/387 ... yes
8/389 ... yes
2/390 ... yes
4/391 ... yes
13/392 ... yes
13/393 ... yes
8/394 ... yes
4/395 ... yes
4/396 ... yes
2/397 ... yes
2/398 ... yes
60/399 ... yes
64/400 ... yes
4/401 ... yes
64/402 ... yes
4/403 ... yes
2/404 ... yes
4/405 ... yes
65/406 ... yes
13/407 ... yes
19/408 ... yes
6/411 ... yes
8/412 ... yes
64/413 ... yes
6/414 ... yes
63/415 ... yes
13/416 ... yes
2/417 ... yes
2/418 ... yes
13/419 ... yes
2/420 ... yes
2/422 ... yes
2/423 ... yes
18/424 ... yes
6/425 ... yes
15/426 ... yes
9/427 ... yes
63/429 ... yes
64/430 ... yes
13/431 ... yes
2/432 ... yes
2/433 ... yes
64/434 ... yes
63/435 ... yes
63/436 ... yes
4/437 ... yes
2/438 ... yes
4/439 ... yes
63/440 ... yes
63/441 ... yes
2/442 ... yes
63/443 ... yes
65/444 ... yes
63/445 ... yes
64/446 ... yes
4/447 ... yes
6/448 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.5.3 ? ... yes (2.6.3)
Git version >= 2.22.0 ? ... yes (2.22.0)
Git user has default SSH configuration? ... yes
Active users: ... 16
Is authorized keys file accessible? ... yes
Checking GitLab App ... Finished
Checking GitLab subtasks ... Finished