Skip to content

It's very easy to accidentally close a merge request when you meant to comment.

Insight

The "Comment" and "Close Merge Request" buttons are so close to each other that merge requests can be accidentally closed. This is similar to the issue described in #255350 (closed), wherein the "Approve" and "Merge were similarly very close together, leading to misclicks and unintentional actions.

Supporting evidence

One poor KDE developer had two of his merge requests accidentally closed in a single week!

https://invent.kde.org/graphics/libksane/-/merge_requests/55:

Screenshot_20211210_111221

https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1253

Screenshot_20211210_111552

In fact, the buttons are quite close together:

Right_next_to_each_other_1

Right_next_to_each_other_2

Action

Move the "Close Merge Request" button farther away from the "Comment" button and make the background red. Red for REJECTED!

Tasks

  • Assign this issue to the appropriate Product Manager, Product Designer, or UX Researcher.
  • Add the appropriate Group (such as ~"group::source code") label to the issue. This helps identify and track actionable insights at the group level.
  • Link this issue back to the original research issue in the GitLab UX Research project and the Dovetail project.
  • Adjust confidentiality of this issue if applicable
Edited by 🤖 GitLab Bot 🤖