Investigate from "Render markdown for Vulnerability Description"
The following discussion from !75859 (merged) should be addressed:
-
@djadmin started a discussion: (+9 comments) Question / Concern:
I verified the changes on the review app instance, and
description_html
is received as empty from the backend.It does work fine on my local instance and @digitalmoksha also confirmed the same. See the related discussion.
- Login to https://gitlab-review-djadmin-vu-pwtlxk.gitlab-review.app/
- Open any security finding from https://gitlab-review-djadmin-vu-pwtlxk.gitlab-review.app/root/webscantest/-/pipelines/44/security
- The description will be shown (which confirms that
description
exist in the DB) - Now, visit any vulnerability page, for instance - https://gitlab-review-djadmin-vu-pwtlxk.gitlab-review.app/root/webscantest/-/security/vulnerabilities/12
- There's no description and can be confirmed as empty from the received response
description_html":""
We can return the
description
as the fail-safe fordescription_html
. It will be rendered rawdata[:description_html] = vulnerability.description_html || vulnerability.description
or rather as markdown
data[:description_html] = vulnerability.description_html || markdown(vulnerability.description)