Skip to content

Migrate `WebHookWorker` to use `params` hash args: Recursion UUID

This issue came from this discussion: !75821 (comment 752958083).

Workers with parameter hash args make it much easier to add new arguments to workers.

We would like to migrate the new webhook detection data being passed through to the worker in !75821 (merged) through the existing data payload to be migrated to being passed through the new params hash instead.

We will follow a multi-step deployment:

  • Release 14.7: !75821 (merged) is adding a params = {} argument to WebHookWorker.
  • Release M+1: !79173 (merged) Pass the webhook recursion detection data through in params, but the worker should continue to expect the data to come through either data or params.
  • Release M+2: !81772 (merged) Remove the handling of the recursion detection data in data.

Note a separate issue #351272 (closed) captures the migration of more arguments to the params arg.

Availability & Testing

  • specs/workers/webhook_worker_spec.rb might be updated to reflect the updated api
  • The recursion detection MR included tests in the unit layer 💯, which should continue to pass or might be updated to reflect the updated api
  • @sgregory2 can also add a feature level test for recursion detection as well, if we feel that we are missing functional coverage
Edited by Luke Duncalfe