Revisit logging in sidekiq-cluster and metrics-server
The following discussion from !75247 (merged) should be addressed:
-
@reprazent started a discussion: (+1 comment) I wonder if we should turn these messages into a hash and include a key that identifies which process we're talking about. Maybe not the process but the function
sidekiq-cluster
,sidekiq-exporter
,sidekiq-worker
,sidekiq-healthcheck
that kind of thing?There's more to be done in that case, so might warrant it's own MR.
The way logging is implemented currently in sidekiq-cluster and related things is not very clear (neither from an implementation perspective nor from a log structure one). It is also inconsistent in the sense that WebExporter
appears to always log unconditionally, while SidekiqExporter inspects a settings switch.
We should probably give this a good look from top to bottom and make sure we log consistently and in a way that makes it easy to understand where log events originate from.