Incorrect Knative version stored in the database after creating a Cloud Run on GKE cluster

Summary

When creating a new Cloud Run on GKE cluster, the Knative version in the Clusters::Applications::Knative model is incorrect.

What is the current bug behavior?

The Knative version is set from the Clusters::Applications::Knative::VERSION constant. This means that even though a current Cloud Run cluster installs Knative 0.8, the version we record is 0.7 (the version of our helm chart).

What is the expected correct behavior?

The Knative version in the database should accurately reflect what is running on the cluster. It should have a value of 0.8.0.

Possible fixes

The Knative version should be dynamically read from the cluster. Details on how to get the version can be found here: https://knative.dev/docs/install/check-install-version/

Definition of Done

  • Dependent on gitlabktl#17 (closed)
  • Using Cloud Run on GKE cluster stores the correct Knative version in the DB
Edited Jan 20, 2020 by Nick Klick
Assignee Loading
Time tracking Loading