Skip to content

Add additional out of scope compliance report violation types

Problem to solve

The basic violation types were added in Introduce concept of Merge Request Violation (&7222 - closed) and Compliance report merge request violations fron... (&6870 - closed).

This issue is to add additional out of scope compliance report violations listed in the epic &5237 (closed).

Proposed solution

Create components that can display the following violations:

  • Pushed to a protected branch
  • CI status
  • Code coverage report
  • Security report
  • Performance report
  • Missing linked issue
  • Last completed pipeline status

Design

Page_1_

Implementation

backend 3️⃣ - we'll have to add a lot of violation types

  1. Add violation types to http://gitlab.com/gitlab-org/gitlab/blob/master/ee/lib/gitlab/compliance_management/violations
  2. Make sure the GraphQL endpoint can pass the new types and any additional info needed for these types
  3. Add new specs

frontend 3️⃣ - we'll have to create a lot of components

  1. Create components to display the following violation types:
    1. Protected branch: Link to branch (GlLink)
    2. CI status: Render ci status (reuse GitLab component)
    3. Code coverage report: Render report (reuse MR widget component)
    4. Security report: Render report (reuse MR widget component)
    5. Performance report: Render report (reuse MR widget component)
    6. Missing linked issue: Text body
    7. Last completed pipeline status: pipeline status (reuse GitLab component)
  2. Add specs to confirm that violations are displayed correctly
Edited by Robert Hunt