Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 43,874
    • Issues 43,874
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1,391
    • Merge requests 1,391
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLabGitLab
  • Issues
  • #346011
Closed (promoted) (promoted)
Open
Created Nov 18, 2021 by Jiaan Louw@jiaan🔴Maintainer

Add additional out of scope compliance report violation types

Problem to solve

The basic violation types were added in Introduce concept of Merge Request Violation (&7222 - closed) and Compliance report merge request violations fron... (&6870 - closed).

This issue is to add additional out of scope compliance report violations listed in the epic &5237.

Proposed solution

Create components that can display the following violations:

  • Pushed to a protected branch
  • CI status
  • Code coverage report
  • Security report
  • Performance report
  • Missing linked issue
  • Last completed pipeline status

Design

Page_1_

Implementation

backend 3️⃣ - we'll have to add a lot of violation types

  1. Add violation types to http://gitlab.com/gitlab-org/gitlab/blob/master/ee/lib/gitlab/compliance_management/violations
  2. Make sure the GraphQL endpoint can pass the new types and any additional info needed for these types
  3. Add new specs

frontend 3️⃣ - we'll have to create a lot of components

  1. Create components to display the following violation types:
    1. Protected branch: Link to branch (GlLink)
    2. CI status: Render ci status (reuse GitLab component)
    3. Code coverage report: Render report (reuse MR widget component)
    4. Security report: Render report (reuse MR widget component)
    5. Performance report: Render report (reuse MR widget component)
    6. Missing linked issue: Text body
    7. Last completed pipeline status: pipeline status (reuse GitLab component)
  2. Add specs to confirm that violations are displayed correctly
Edited Mar 22, 2022 by Robert Hunt
Assignee
Assign to
Time tracking