Skip to content

Terms of service don't enforce acceptance of changed terms

Summary

If All users must accept the Terms of Service and Privacy Policy to access GitLab is activated, users that have never accepted the TOS are redirected to /-/users/terms and have to accept the TOS or be logged out.

After changing the terms, users that accepted a prior version of the TOS are currently not being redirected to this dialog.

Thus, after changing the TOS, their acceptance is not being enforced for existing users.

Steps to reproduce

  • Enter Terms of Service and activate All users must accept the Terms of Service and Privacy Policy to access GitLab
  • Save the changes
  • As a new user "UserA", you will be redirected the /-/users/terms dialog and have to accept the TOS or be logged out. Accept the TOS
  • Change the Terms of Service and save the changes
  • "UserA" is not redirected to the /-/users/terms dialog as expected

What is the current bug behavior?

Acceptance of changed TOS is not enforced for users that have accepted prior versions of the TOS even if All users must accept the Terms of Service and Privacy Policy to access GitLab is activated.

What is the expected correct behavior?

After changing the TOS, all users have to accept them if All users must accept the Terms of Service and Privacy Policy to access GitLab is activated.

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info 

System information
System:		Ubuntu 18.04
Proxy:		no
Current User:	git
Using RVM:	no
Ruby Version:	2.7.4p191
Gem Version:	3.1.4
Bundler Version:2.1.4
Rake Version:	13.0.6
Redis Version:	6.0.16
Git Version:	2.33.0.
Sidekiq Version:6.2.2
Go Version:	unknown

GitLab information
Version:	14.4.1-ee
Revision:	abc23a14bac
Directory:	/opt/gitlab/embedded/service/gitlab-rails
DB Adapter:	PostgreSQL
DB Version:	12.7
URL:		http://gitlab.local
HTTP Clone URL:	http://gitlab.local/some-group/some-project.git
SSH Clone URL:	git@gitlab.local:some-group/some-project.git
Elasticsearch:	no
Geo:		no
Using LDAP:	no
Using Omniauth:	yes
Omniauth Providers:

GitLab Shell
Version:	13.21.1
Repository storage paths:
- default: 	/var/opt/gitlab/git-data/repositories
GitLab Shell path:		/opt/gitlab/embedded/service/gitlab-shell
Git:		/opt/gitlab/embedded/bin/git

Results of GitLab application Check

Expand for output related to the GitLab application check 
Checking GitLab subtasks ...


Checking GitLab Shell ...


GitLab Shell: ... GitLab Shell version >= 13.21.1 ? ... OK (13.21.1)
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Internal API available: OK
Redis available via internal API: OK
gitlab-shell self-check successful


Checking GitLab Shell ... Finished


Checking Gitaly ...


Gitaly: ... default ... OK


Checking Gitaly ... Finished


Checking Sidekiq ...


Sidekiq: ... Running? ... yes
Number of Sidekiq processes (cluster/worker) ... 1/1


Checking Sidekiq ... Finished


Checking Incoming Email ...


Incoming Email: ... Reply by email is disabled in config/gitlab.yml


Checking Incoming Email ... Finished


Checking LDAP ...


LDAP: ... LDAP is disabled in config/gitlab.yml


Checking LDAP ... Finished


Checking GitLab App ...


Git configured correctly? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... yes
Uploads directory tmp has correct permissions? ... yes
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
Projects have namespace: ...
2/1 ... yes
4/2 ... yes
1/3 ... yes
Redis version >= 5.0.0? ... yes
Ruby version >= 2.7.2 ? ... yes (2.7.4)
Git version >= 2.33.0 ? ... yes (2.33.0)
Git user has default SSH configuration? ... yes
Active users: ... 2
Is authorized keys file accessible? ... yes
GitLab configured to store new projects in hashed storage? ... yes
All projects are in hashed storage? ... yes
Elasticsearch version 7.x (6.4 - 6.x deprecated to be removed in 13.8)? ... skipped (elasticsearch is disabled)


Checking GitLab App ... Finished


Checking GitLab subtasks ... Finished