Skip to content

Design Management: Error is thrown if a user without Avatar icon comments on a design

Summary

After an user without an set Avatar (in user profile) comments on a design, this design could not be loaded again resulting in follownig errors:

image

image

Steps to reproduce

  • Design Management must be activated.
  • Log on with a User without an set Avatar (default gray avatar icon)
  • create a new design or open an existing one and add a comment.
  • after saving the design could not be loaded any more with the error listed above.

As a workaround to fix the issue:

  • simply assign an Avatar image - afterwards the designs and comments can be loaded again.

Example Project

None for now, if the bug is not easily reproduceable I will provide one.

What is the current bug behavior?

See above

What is the expected correct behavior?

The design could be loaded with all comments without errors.

Relevant logs and/or screenshots

Both errors are observed on the client. Have not found an error logging on the backend for now.

image

follow up error

image

Output of checks

Bug happend on onpromise installation of Gitlab

Results of GitLab environment info

Expand for output related to GitLab environment info 
System information
System:         Ubuntu 16.04
Proxy:          no
Current User:   git
Using RVM:      no
Ruby Version:   2.6.3p62
Gem Version:    2.7.9
Bundler Version:1.17.3
Rake Version:   12.3.2
Redis Version:  3.2.12
Git Version:    2.22.0
Sidekiq Version:5.2.7
Go Version:     go1.6.2 linux/amd64


GitLab information
Version:        12.3.5-ee
Revision:       9dbaa740018
Directory:      /opt/gitlab/embedded/service/gitlab-rails
DB Adapter:     PostgreSQL
DB Version:     10.9
URL:            https://gitlab.ihr.infoniqa.local
HTTP Clone URL: https://gitlab.ihr.infoniqa.local/some-group/some-project.git
SSH Clone URL:  git@gitlab.management.ihr.infoniqa.local:some-group/some-project.git
Elasticsearch:  no
Geo:            no
Using LDAP:     yes
Using Omniauth: yes
Omniauth Providers: keycloak


GitLab Shell
Version:        10.0.0
Repository storage paths:
  • default: /var/opt/gitlab/git-data/repositories GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell Git: /opt/gitlab/embedded/bin/git

Results of GitLab application Check

Expand for output related to the GitLab application check 
Checking GitLab subtasks ...


Checking GitLab Shell ...


GitLab Shell: ... GitLab Shell version >= 10.0.0 ? ... OK (10.0.0)
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Check GitLab API access: OK
Redis available via internal API: OK


gitlab-shell self-check successful


Checking GitLab Shell ... Finished


Checking Gitaly ...


Gitaly: ... default ... OK


Checking Gitaly ... Finished


Checking Sidekiq ...


Sidekiq: ... Running? ... yes
Number of Sidekiq processes ... 1


Checking Sidekiq ... Finished


Checking Incoming Email ...


Incoming Email: ... Reply by email is disabled in config/gitlab.yml


Checking Incoming Email ... Finished


Checking LDAP ...


LDAP: ... Server: ldapmain
LDAP authentication... Success
LDAP users with access to your GitLab server (only showing the first 100 results)
User output sanitized. Found 100 users of 100 limit.


Checking LDAP ... Finished


Checking GitLab App ...


Git configured correctly? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... yes
Uploads directory tmp has correct permissions? ... no
Try fixing it:
sudo chown -R git /var/opt/gitlab/gitlab-rails/uploads
sudo find /var/opt/gitlab/gitlab-rails/uploads -type f -exec chmod 0644 {} ;
sudo find /var/opt/gitlab/gitlab-rails/uploads -type d -not -path /var/opt/gitlab/gitlab-rails/uploads -exec chmod 0700 {} ;
For more information see:
doc/install/installation.md in section "GitLab"
Please fix the error above and rerun the checks.
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
Projects have namespace: ...
4/3 ... yes
4/4 ... yes
3/5 ... yes
4/9 ... yes
4/11 ... yes
4/12 ... yes
4/14 ... yes
4/15 ... yes
4/18 ... yes
16/22 ... yes
3/25 ... yes
4/26 ... yes
4/27 ... yes
4/28 ... yes
4/29 ... yes
4/30 ... yes
16/33 ... yes
4/35 ... yes
4/36 ... yes
9/38 ... yes
4/40 ... yes
13/42 ... yes
4/43 ... yes
4/44 ... yes
4/45 ... yes
4/46 ... yes
4/48 ... yes
4/49 ... yes
4/50 ... yes
5/55 ... yes
4/56 ... yes
4/57 ... yes
4/58 ... yes
4/59 ... yes
4/60 ... yes
4/61 ... yes
4/62 ... yes
4/63 ... yes
4/64 ... yes
4/66 ... yes
4/69 ... yes
39/70 ... yes
4/73 ... yes
4/74 ... yes
4/75 ... yes
4/77 ... yes
4/79 ... yes
4/80 ... yes
39/81 ... yes
48/82 ... yes
8/83 ... yes
5/84 ... yes
39/86 ... yes
4/87 ... yes
4/88 ... yes
4/91 ... yes
4/92 ... yes
4/93 ... yes
39/94 ... yes
10/95 ... yes
4/96 ... yes
9/97 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.5.3 ? ... yes (2.6.3)
Git version >= 2.22.0 ? ... yes (2.22.0)
Git user has default SSH configuration? ... yes
Active users: ... 19
Is authorized keys file accessible? ... yes
Elasticsearch version 5.6 - 6.x? ... skipped (elasticsearch is disabled)


Checking GitLab App ... Finished


Checking GitLab subtasks ... Finished

Possible fixes

(If you can, link to the line of code that might be responsible for the problem)

Edited by 🤖 GitLab Bot 🤖