Follow-up from "Geo: make console messages consistent"
The following discussion from !16584 (merged) should be addressed:
-
@mkozono started a discussion: (+1 comment) I think it would be nice to align the endpoints further by reusing a shared message entity i.e. pulling the
Messageentity out of theInternalPostReceivemodule to be on its own:class ConsoleMessage < Grape::Entity expose :message expose :type endDo you think that direction makes sense (for later)?
I assume you saw the
basic/alertmessage type names and preferinfo/warning. I think I agree. Annoyingly it will take a backwards-compatible Gitaly release and then next Rails release to change those types.