Skip to content

Dockerfiles moved when using GUI Edit tool

Summary

Using the GitLab.com Edit tool on Dockerfiles within sub-directories causes the Dockerfile to be moved to the root directory of the repository. If the Dockerfile is the only file present within said sub-directory, that specific sub-directory is also deleted when the file is moved. This does not occur if you use the WebIDE.

I was unable to replicate this on a self-managed 12.3.5-ee instance, but I am able to replicate the behavior on our current nightly release (gitlab-ee_12.3.5+rnightly.132802.d90da2b1-0_).

Steps to reproduce

  1. Create a new, empty repository on GitLab.com

  2. Add a sub-directory, and a Dockerfile within that sub-directory

  3. Use the Edit button to add content to the Dockerfile, and commit your change to the master branch.

Example Project

https://gitlab.com/calebw/dockerfile-delete/tree/master

Note: I've reproduced the issue on this repo, so it currently only contains a Dockerfile.

What is the current bug behavior?

Committing changes via the Edit tool on a Dockerfile located in a sub-directory to be moved to the root directory of the repo, and the sub-directory then deleted if it was the only file present.

What is the expected correct behavior?

Committing changes via the Edit tool on a Dockerfile should not move its location.

Output of checks

This bug happens on GitLab.com as well as the current nightly release (gitlab-ee_12.3.5+rnightly.132802.d90da2b1-0).

Results of GitLab environment info

Expand for output related to GitLab environment info 


System information
System:		Ubuntu 18.04
Proxy:		no
Current User:	git
Using RVM:	no
Ruby Version:	2.6.3p62
Gem Version:	2.7.9
Bundler Version:1.17.3
Rake Version:	12.3.3
Redis Version:	3.2.12
Git Version:	2.22.0
Sidekiq Version:5.2.7
Go Version:	unknown

GitLab information
Version:	12.3.0-pre
Revision:	30639b41c57
Directory:	/opt/gitlab/embedded/service/gitlab-rails
DB Adapter:	PostgreSQL
DB Version:	10.9
URL:		https://gitlab.calebw.tech
HTTP Clone URL:	https://gitlab.calebw.tech/some-group/some-project.git
SSH Clone URL:	git@gitlab.calebw.tech:some-group/some-project.git
Elasticsearch:	no
Geo:		no
Using LDAP:	no
Using Omniauth:	yes
Omniauth Providers:

GitLab Shell
Version:	10.2.0
Repository storage paths:
- default: 	/var/opt/gitlab/git-data/repositories
GitLab Shell path:		/opt/gitlab/embedded/service/gitlab-shell
Git:		/opt/gitlab/embedded/bin/git

Results of GitLab application Check

Expand for output related to the GitLab application check 


Checking GitLab subtasks ...

Checking GitLab Shell ...

GitLab Shell: ... GitLab Shell version >= 10.2.0 ? ... OK (10.2.0)
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Internal API available: OK
Redis available via internal API: OK
gitlab-shell self-check successful

Checking GitLab Shell ... Finished

Checking Gitaly ...

Gitaly: ... default ... OK

Checking Gitaly ... Finished

Checking Sidekiq ...

Sidekiq: ... Running? ... yes
Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Incoming Email ...
Incoming Email: ... Reply by email is disabled in config/gitlab.yml
Checking Incoming Email ... Finished
Checking LDAP ...
LDAP: ... LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab App ...
Git configured correctly? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... yes
Uploads directory tmp has correct permissions? ... yes
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
Projects have namespace: ...
1/1 ... yes
2/3 ... yes
2/4 ... yes
2/5 ... yes
2/6 ... yes
6/7 ... yes
2/8 ... yes
2/9 ... yes
2/10 ... yes
2/11 ... yes
2/15 ... yes
2/18 ... yes
2/19 ... yes
2/21 ... yes
2/22 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.5.3 ? ... yes (2.6.3)
Git version >= 2.22.0 ? ... yes (2.22.0)
Git user has default SSH configuration? ... yes
Active users: ... 5
Is authorized keys file accessible? ... yes
Elasticsearch version 5.6 - 6.x? ... skipped (elasticsearch is disabled)
Checking GitLab App ... Finished
Checking GitLab subtasks ... Finished

Possible fixes

(If you can, link to the line of code that might be responsible for the problem)