Remove deprecated fullPath arguments from frontend DAST mutations
The following discussion from !72478 (merged) should be addressed:
-
@philipcunningham started a discussion: (+1 comment) @djadmin @pgascouvaillancourt just a heads-up that this merge request deprecates
fullPath
from a number ofdast
mutations (dastProfileRun
,dastProfileUpdate
,dastScannerProfileDelete
,dastScannerProfileUpdate
,dastSiteProfileDelete
,dastSiteProfileDelete
) because it isn't required to qualify them.
In !72478 (merged), the fullPath
argument has been deprecated in several GraphQL mutations that don't actually need it to function. The following mutations are affected:
dastProfileRun
dastProfileUpdate
dastScannerProfileDelete
dastScannerProfileUpdate
dastSiteProfileDelete
dastSiteProfileUpdate
Let's cleanup the frontend code so that we don't unnecessarily pass fullPath
to those mutations. Here are the Vue components we should look at:
-
ee/app/assets/javascripts/security_configuration/dast_profiles/components/dast_saved_scans_list.vue
-
ee/app/assets/javascripts/on_demand_scans_form/components/on_demand_scans_form.vue
-
ee/app/assets/javascripts/security_configuration/dast_profiles/components/dast_profiles.vue
-
ee/app/assets/javascripts/security_configuration/dast_profiles/dast_scanner_profiles/components/dast_scanner_profile_form.vue
-
ee/app/assets/javascripts/security_configuration/dast_profiles/dast_site_profiles/components/dast_site_profile_form.vue
Note: The
Create
mutations still require thefullPath
argument to be passed. However, in some places in the codebase, theCreate
andUpdate
mutations are handled by the same bit of code to reduce duplication. In those cases, we'll want to make sure the argument is removed from theUpdate
mutation only.