Skip to content
GitLab
Next
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 44,761
    • Issues 44,761
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1,329
    • Merge requests 1,329
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLabGitLab
  • Issues
  • #343298
Closed
Open
Issue created Oct 19, 2021 by Hannah Sutor@hsutorDeveloper

Check LDAP user status on sign-in with other authentication methods

Summary

If LDAP is used as the authentication method, an ldap_blocked user will be unblocked on sign-in if the user is valid in LDAP. However, when a non-LDAP authentication method is configured alongside LDAP (such as Azure AD) and the user becomes ldap_blocked we do not recheck the LDAP user status on sign-in.

Scenario

User becomes ldap_blocked by either LdapSyncWorker (once daily) or the default 1-hour sync_time. This can happen either due to transient communication issues with LDAP, or maybe the user actually was disabled/removed from LDAP for a period of time.

When signing in via another method, if the user is ldap_blocked we should proactively check with LDAP to see if the user is now active. If yes, unblock the user and allow sign-in.

Problem This Solves

In this issue, if the LDAP server is flaky or cannot be reached, users are immediately blocked, even when another authentication method is configured and status is maintained there.

This was causing users to be unable to login, and a manual sync initiated by the customer had to take place in order to reset the users back to "active".

Edited Oct 19, 2021 by Drew Blessing
Assignee
Assign to
Time tracking