(follow up issue) HTML error page response for ZenTao

About

This was generated from this discussion !69602 (comment 705842813).

If a user encounters an error when viewing a ZenTao issue, they currently see a JSON error response returned in the browser. We should improve this to display an HTML-formatted page.

Note: This is a problem with Jira too !69602 (comment 706456391) so a page that could be reused would be great.

assigned to @icbd

added IntegrationZenTao + 1 deleted label

set weight to 1

I'll unassign from @icbd because this issue likely needs some designs. cc @lvanc

@.luke thanks for creating this issue. I'll take a pass at it.

We already have the designs from @lvanc, thanks! I'm assigning this back to @icbd.

@icbd If you have any questions related to design (@lvanc) or technical writing (@kpaizee), we are happy to assist you.

unassigned @icbd

changed the description

added frontend workflowdesign labels

added sectiondev label

@.luke, please can you add a type label to this issue to help with issue discovery in issue reports.

added auto updated label

added UX label and removed auto updated label

assigned to @lvanc

@mushakov any thoughts on priority for this?

@lvanc This seems like a straightforward page. So if the effort is low we should do it soon!

@arturoherrero Is this something we could do with just front-end work?

@mushakov sounds good! I'll add a (hopefully low effort) proposal.

mentioned in issue gitlab-jh/gitlab#285 (closed)

added groupintegrations [DEPRECATED] label

added 1 design

added 1 design

started a discussion on current-jira-error-msg.png

started a discussion on proposal-generic-error-msg.png

started a discussion on proposal-generic-error-msg.png

started a discussion on proposal-generic-error-msg.png

added Technical Writing label

added twdoing label

added tw-weight3 label

added workflowready for development label and removed workflowdesign label

assigned to @icbd and unassigned @lvanc

added workflowproblem validation label and removed workflowready for development label

assigned to @lvanc

added workflowdesign label and removed workflowproblem validation label

mentioned in issue #337996 (closed)

updated 1 design

changed the description

updated 1 design

@.luke, please can you add a type label to this issue to help with issue discovery in issue reports.

added auto updated label

added featureenhancement label

added typefeature label

added workflowready for development label and removed workflowdesign label

@.luke @lvanc could we render 404 page in this case?

diff --git a/ee/app/controllers/projects/integrations/jira/issues_controller.rb b/ee/app/controllers/projects/integrations/jira/issues_controller.rb
index 5e92d66bf61..dd21962b67f 100644
--- a/ee/app/controllers/projects/integrations/jira/issues_controller.rb
+++ b/ee/app/controllers/projects/integrations/jira/issues_controller.rb
@@ -37,6 +37,9 @@ def show
           respond_to do |format|
             format.html do
               @issue_json = issue_json
+              if @issue_json.nil?
+                not_found
+              end
             end
             format.json do
               render json: issue_json

It could be a recoverable (temporary) problem in the remote service, so it's not exactly a 404.

mentioned in issue gitlab-jh/gitlab#321

changed milestone to %Backlog

mentioned in issue #338178 (closed)

added Seeking community contributions label

Thanks for working on this @icbd! We've removed the Seeking community contributions label to avoid having multiple people working on the same issue.

removed Seeking community contributions label

mentioned in commit gitlab-jh/jh-team/gitlab@96230238

mentioned in merge request !88035 (merged)

mentioned in commit gitlab-jh/jh-team/gitlab@ad209fac

Labelling as workflowin review because @icbd is working on this !88035 (merged)

changed milestone to %15.1

added workflowin review label and removed workflowready for development label

mentioned in commit gitlab-jh/jh-team/gitlab@8368f5f8

mentioned in commit gitlab-jh/jh-team/gitlab@b7009a87

mentioned in commit 7fa103cf

changed milestone to %15.2

added missed:15.1 label

!88035 (merged) solved this issue.

closed

added devopsmanage label and removed 1 deleted label

added groupimport and integrate label and removed groupintegrations [DEPRECATED] label