Add container around header and tabs in MR diff view
Background
In #340761 (closed) we made a change to the view of the merge request Changes tab (/diffs
) to always be full-width and have the diffs use all available space.
Before, diffs were only full-width when the file browser was open or when using the “side-by-side” mode.
Problem
Tabs constantly shift between fluid and fixed if users go back and forth between tabs. From going through all the prior research in ux-research#1534 (closed), a lot of developers tend to go back and forth between tabs like this.
#341931 (closed)
Feedback fromThe change of location of the navigation bar is irritating to me. I usually toggle between "Overview" and "Changes". This change makes it harder to toggle between these two as I need to re-adjust my eyes every time and we don't have shortcuts to go to these pages.
I like to see the diffs in full width, but it can be jarring when switching tabs.
Proposal
From @psimyn's comment: Add the fixed container back to the header and tabs. It doesn't look great (and it was our previous behavior for side-by-side and file tree views), but it will alleviate any frustration users are feeling from the tabs jumping around.