Diffs "Jump To Next Unresolved Discussion" button is non-functional / difficult to use
Summary
The "Jump To Next Unresolved Discussion" button in the Merge Request Changes tab does not work properly.
Steps to reproduce
- Go to an MR with at least 2 unresolved discussions (like: !37286 (diffs))
- Click the "Jump To Next Unresolved Discussion" button
- Repeat step 2
Example Project
What is the current bug behavior?
In the best case, the button sometimes jumps to an unresolved discussion (but it's not usually the next unresolved discussion).
In the worst case, the button jumps to a place in the page, but it's not really noticeably "close" to a discussion, scrolling up or down doesn't reveal a discussion just off the page, so it's not clear what it's jumping to.
Other common cases:
- A click jumps to a discussion, but the next click... also jumps to that discussion? It sort of gets "stuck". The next click usually goes to another discussion, but not often the next one.
- A click jumps to somewhere below where the virtual scroller has rendered, which is just a couple frames of blank white screen, but then the scroll jumps to the very top of the page instead of waiting for the files to actually load in.
What is the expected correct behavior?
Basically the behavior of a the Jump To Next Unresolved Dicsussion button on a fresh load of the MR page on the Overview tab.
It's not perfect, but it more or less goes to the next unresolved discussion every time you click the button.
To be fair, this also has some problems, like it doesn't seem to scroll to the exactly correct position, so it's not clear what I should be looking at when multiple discussions are are screen, but it is roughly scrolling through the discussions in sequence.