User approval: Rejecting reloads page
Summary
When reviewing user pending approval, and choosing Approve, the user is approved, and subsequently removed from the pending list, without reloading the page.
However, when choosing Reject, the page is reloaded and jumps back to the "Active" list of users.
This adds additional clicks to the review process, which is especially bad on sites that have a lot of spam registrations (due to GitLab not supporting any sensible anti-spam measures).
Steps to reproduce
- Enable new user approval in settings.
- Register a new user
- Go to
/admin/users?filter=blocked_pending_approval - Click the action menu for the user, and select Reject.
- Confirm rejection with the "Reject" button.
What is the current bug behavior?
The use ris rejected, the page reloads, and the "Active" list is displayed (in contrast to when choosing "Approve").
What is the expected correct behavior?
The "Pending approval" list should still be displayed, to approve or reject more users (like when choosing "Approve").