Skip to content

When suggestions overlap, is it possible to trap this before attempting to apply the suggestions?

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

Summary

While reviewing ~15 suggestions in !71500 (merged), I selected 13 of them to apply.

However, they failed to apply with

Suggestions are not applicable as their lines cannot overlap. 

image

Raising this as a bug because of the UX experience.

Steps to reproduce

  • Make multiple suggestions on a MR, and (I suppose) make some of them overlap.
  • Add them all to the batch
  • Try to apply them all.

Example Project

What is the current bug behavior?

The conflict is raised once all the suggestions have been added to the batch.

What is the expected correct behavior?

Flag the conflict when the second suggestion is added to the batch.

Relevant logs and/or screenshots

Output of checks

This bug happens on GitLab.com

GitLab Enterprise Edition 14.4.0-pre f1930dcc

Possible fixes

Edited by 🤖 GitLab Bot 🤖