Confusion when viewing diffs of a specific commit

Summary

If you follow a link to a specific commit in an MR it is not evident that you are viewing the diffs of the not most recent commit. This can be confusing when referencing rebase or other commits.

Steps to reproduce

  • View this link of a commit reference to a specific MR
  • View this link of the MR directly

If you weren't fully aware of the link you'd be confused by the diffs in the first link, especially because the MR files changed doesn't match that of the actual diff view.

Example Project

(If possible, please create an example project here on GitLab.com that exhibits the problematic behavior, and link to it here in the bug report)

(If you are using an older version of GitLab, this will also determine whether the bug is fixed in a more recent version)

What is the current bug behavior?

Screen_Shot_2019-10-16_at_2.39.06_PM

What is the expected correct behavior?

Screen_Shot_2019-10-16_at_2.38.50_PM

Is the direct example. But perhaps some way to flag to the user that they are not viewing the most recent commit in the MR when viewing diffs would be an improvement to avoid the confusion.

Relevant logs and/or screenshots

(Paste any relevant logs - please use code blocks (```) to format console output, logs, and code as it's tough to read otherwise.)

Output of checks

(If you are reporting a bug on GitLab.com, write: This bug happens on GitLab.com)

Results of GitLab environment info

Expand for output related to GitLab environment info

(For installations with omnibus-gitlab package run and paste the output of: sudo gitlab-rake gitlab:env:info)

(For installations from source run and paste the output of: sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production)

Results of GitLab application Check

Expand for output related to the GitLab application check

(For installations with omnibus-gitlab package run and paste the output of: sudo gitlab-rake gitlab:check SANITIZE=true)

(For installations from source run and paste the output of: sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)

(we will only investigate if the tests are passing)

Possible fixes

(If you can, link to the line of code that might be responsible for the problem)

Assignee Loading
Time tracking Loading