Skip to content

Remove deprecation warning: "Rendering actions with '.' in the name is deprecated:"

Problem

When running specs following deprecation warnings are emitted

Rendering actions with '.' in the name is deprecated:

Why?

Using . in template names has been deprecated in https://github.com/rails/rails/pull/39164.

Proposed solution

For example:

Bad

render 'shared/logo.svg'

Good

render partial: 'shared/logo', formats: :svg

OR if the used view is a template:

render template: 'errors/access_denied', formats: :svg

Note, the additional partial: (or template:) and formats: options.

Occurrences

There's a list of occurrences extracted from CI logs.

  • app/controllers/application_controller.rb:130 - !76011 (merged) !83015 (merged)
    • errors/kerberos_denied.html.haml
    • errors/not_found.html.haml
    • help/show.html.haml
    • errors/git_not_found.html
    • layouts/xml.atom
  • app/helpers/appearances_helper.rb:42 - !72842 (merged)
    • shared/_logo.svg
  • app/helpers/appearances_helper.rb:49 - !72842 (merged)
    • shared/_logo_type.svg
  • app/helpers/commits_helper.rb:30 - !75772 (merged)
    • projects/commits/_commit.html
  • app/helpers/icons_helper.rb:14 - !73291 (merged)
    • shared/icons/_icon_contribution_analytics.svg
    • shared/icons/_icon_group_webhook.svg
    • shared/icons/_icon_premium.svg
    • shared/icons/_icon_push_rules.svg
    • shared/icons/_icon_search_avatar.svg
    • shared/icons/_trial_activated_banner.svg
    • shared/icons/_add_new_group.svg
    • shared/icons/_add_new_project.svg
    • shared/icons/_add_new_user.svg
    • shared/icons/_configure_server.svg
    • shared/icons/_icon_audit_events_purple.svg
    • shared/icons/_icon_mattermost.svg
    • shared/icons/_mattermost_logo.svg
    • shared/icons/_icon_burndown_charts.svg
    • shared/icons/_illustration_no_commits.svg
    • shared/icons/_icon_explore_groups_splash.svg
    • shared/icons/_icon_pencil.svg
    • shared/icons/_icon_burndown_chart_splash.svg
    • shared/icons/_icon_timer.svg
    • shared/icons/_gitea_logo.svg
    • shared/icons/_issues.svg
    • shared/icons/_icon_empty_groups.svg
    • shared/icons/_icon_service_desk.svg
    • shared/icons/_icon_arrow_right.svg
    • shared/icons/_mr_bold.svg
    • shared/icons/_icon_commit.svg
  • app/views/errors/omniauth_error.html.haml:4 - !73415 (merged)
    • shared/errors/_graphic_422.svg
  • app/views/layouts/header/_logo_with_title.html.haml:2 - !73417 (merged)
    • shared/_logo.svg
  • app/views/layouts/header/_logo_with_title.html.haml:4 - !73417 (merged)
    • shared/_logo_type.svg
  • app/views/projects/issues/_service_desk_info_content.html.haml:8 - !73418 (merged)
    • shared/empty_states/icons/_service_desk_callout.svg
  • ee/app/controllers/ee/projects/issues_controller.rb:106 - !75775 (merged)
    • vulnerabilities/_unable_to_link_vulnerability.html.haml
  • ee/app/controllers/ee/projects/issues_controller.rb:99 - !75775 (merged)
    • vulnerabilities/issue_description.md.erb
  • ee/app/helpers/vulnerabilities_helper.rb:49 - !73420 (merged) !75776 (closed)
    • vulnerabilities/jira_issue_description.md.erb
  • ee/app/presenters/vulnerability_presenter.rb:52 - !75777 (merged)
    • vulnerabilities/jira_issue_description.md.erb
  • ee/app/services/issues/build_from_vulnerability_service.rb:20 - !75778 (merged)
    • vulnerabilities/issue_description.md.erb
  • ee/app/services/issues/create_from_vulnerability_data_service.rb:37 - !75779 (merged)
    • vulnerabilities/issue_description.md.erb
  • ee/app/services/merge_requests/create_from_vulnerability_data_service.rb:88 - !75781 (merged)
    • vulnerabilities/merge_request_description.md.erb
    • vulnerabilities/remediation.patch.erb
  • spec/views/projects/commits/_commit.html.haml_spec.rb:22 - !75782 (merged)
    • projects/commits/_commit.html.haml
  • spec/views/shared/ssh_keys/_key_details.html.haml_spec.rb:15 - !75785 (merged)
    • shared/ssh_keys/_key_delete.html.haml
  • spec/views/shared/ssh_keys/_key_details.html.haml_spec.rb:7 - !75785 (merged)
    • shared/ssh_keys/_key_delete.html.haml
Edited by Siddharth Asthana