Replace `approvers` to distinguish users from groups.
This page may contain information related to upcoming products, features and functionality. It is important to note that the information presented is for informational purposes only, so please do not rely on the information for purchasing or planning purposes. Just like with all projects, the items mentioned on the page are subject to change or delay, and the development, release, and timing of any products, features, or functionality remain at the sole discretion of GitLab Inc.
Why are we doing this work
The initial approvers
attribute under actions
had some ambiguity between users and groups. On top of that groups search by path
can lead to multiple results.
Relevant links
Non-functional requirements
-
Documentation: -
Feature flag: -
Performance: -
Testing:
Implementation plan
-
backend Reuse existing logic for considering approvers (wider group than project members) -
backend Replace approvers
byuser_approvers
andgroup_approvers
-
backend Add user_approvers_ids
andgroup_approvers_ids
for a faster and more deterministic result. -
backend Update YAML schema to require any of the above.
Partial view of the existing yaml:
scan_result_policy:
- name: critical vulnerability CS approvals
...
rules:
- type: scan_finding
...
actions:
- type: require_approval
...
approvers:
- adalberto.dare
Edited by Zamir Martins