[FE] - Experience for early activation using cloud on instance with active non cloud license

@teresatison I have one outstanding question based on the description and design. I'll leave this task in workflowrefinement until the question has been answered:

We should define an experience that allows customers with an active (legacy) license to add a new cloud license early, ...

Right now we only show the Enter activation code button whenever the current license is a legacy license file (of type LICENSE_FILE_TYPE). Would this mean that we would always show the activation button, or only when the user is exempt? In the latter case, we would have trouble knowing when that is since the exemption (as far as I understand) follows the license and not the user.

Breakdown

Task

~~Depending on the answer to the above, we should show the activation button, so the user can add a cloud license even if they have a legacy license installed~~ Update: It should remain how it is currently working. See here: #341965 (comment 820069343)
Rename the activation button from Activate cloud license to Enter activation code.
Change modal size to small, i.e. use size: 'sm' prop

If we are to always show the activation (current assumption) the weight of this task is 1.

Related tasks:

This task takes care of displaying future-dated licenses in the subscription history table: #341171 (comment 812691099)
This task took care of displaying the success alert when uploading the license: #225834 (closed)
This task takes care of displaying the information alert to list any future-dated licenses: https://gitlab.com/gitlab-org/gitlab/-/issues/337026

set weight to 1

removed [deprecated] Accepting merge requests label

@mlunoe

At the time support generates a cloud license for the customer, the supersonic flag TurnOnCloudLicensing__c will be set to yes in the backend. This data can be used to render the display that allows an exempt customer to download the cloud license file.

Right now we only show the Enter activation code button whenever the current license is a legacy license file (of type LICENSE_FILE_TYPE). Would this mean that we would always show the activation button, or only when the user is exempt? In the latter case, we would have trouble knowing when that is since the exemption (as far as I understand) follows the license and not the user.

@teresatison That is exactly the point of my question: If the TurnOnCloudLicensing__c flag is set on the license, which it looks like it does, it will be difficult to tie this attribute to the user who is currently viewing the page. Therefore, also difficult to know whether to show/hide specific UI. Therefore, my assumption is that we would always show the activation button.

Furthermore, we show a banner on top of the subscription details card. I am in the process of figuring out whether that should always show as well:

@timnoah Let me know your thoughts here and/or in the UX issue: #341967[Upgrade_from_a_legacy_license.png].

@mlunoe The subscription history would have information on what the customer activated. And if the customer has activated a cloud license, then we should not show this activation button.

@mlunoe agree with @teresatison I've left comments on the UX issue.

I'll express the same concern here. I'm a little confused about the above scenario. It appears from the example the instance already has a cloud license activated. The banner and the activate cloud license button should be hidden in this case. The problem we are trying to solve is when an instance has an active (legacy) license and activates a cloud license early (before the current license term has expired). I hope this helps to add further context

@timnoah Oh, I see. Thank you for explaining this to me. I think my confusion stemmed from that this functionality is already implemented and I thought we wanted to change this flow. But since is already how it works the only thing that is left here to do is tweak the size of the modal and the button text :thumbs-up:

I'll update the issue weight and workflow to reflect this.

No problem at all @mlunoe I can imagine how complicated tracking the issues can get since we are dealing with many edge cases. Feel to reach out anytime to be unblocked, more than happy to help where I can.