ZenTao integration: add zentao_issues_list_bundle tests

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

• Close this issue

The following discussion from !69929 (merged) should be addressed:

• @pslaughter started a discussion: (+3 comments)

  suggestion: Thanks for refining these specs @JeremyWuuuuu + also thanks @nmezzopera & @ntepluhina for catching the pre-existing issues 👍

  @nmezzopera and I hopped on a call to discuss the broader context of these Zentao MR's and discovered that these new spec additions actually aren't even needed. For instance, this spec specifically targets external_issues_list_empty_state.vue which already has its own unit tests in external_issues_list_empty_state_spec.js. Also, the zentao_issues_list_root_spec.js targets external_issues_list_root.vue which has it's own unit tests.

  Okay Paul, what do you suggest?

  The new modules being added here are the resolvers/zentao_issues.js and the zentao_issues_list_bundle.js. The page bundles are usually covered by feature specs (which we can handle in a follow-up). Let's repurpose the zentao_issues_list_root_spec to just target the new resolver specifically.

  Here's a patch for what I'm suggesting:

  0001-Remove-redundant-tests-and-add-unit-test-for-zentao-.patch

  What all does this patch do?

  • Removes the specs being introduced in this MR.
  • Adds a new zentao_issues_spec as a unit test for the zentao_issues resolver.
  • Updates the mock_data since it included some properties that are Jira specific. @JeremyWuuuuu could you double check that the mock_data includes the exact kind of responses we would expect from Zentao? For instance there's some web_url that include atlassian.com? Could we copy over a real Zentao API response here?

  It would be nice to have some sort of test for the zentao_issues_list_bundle, but it might be best to cover this with a FE integration test. Could we create a follow-up for this? WDYT @nmezzopera?