Skip to content

Allow or remove `include ::ActionView::Helpers::UrlHelper` in specs

include ActionView::Helpers::UrlHelper adds ~40 methods to the class. And it caused a bug in https://gitlab.com/gitlab-org/ci-cd/release-group/release/-/issues/84

Most of the time it's included for link_to method, which can be replaced with:

url = Gitlab::Routing.url_helpers.project_blob_path(...)

ActionController::Base.helpers.link_to(url, link_text)

https://gitlab.com/gitlab-org/gitlab/-/blob/50e7fd1ffd5a1c8d41e949f6ece623485542e770/.rubocop_todo/rails/include_url_helper.yml

  - ee/spec/helpers/ee/projects/security/configuration_helper_spec.rb
  - ee/spec/lib/banzai/filter/cross_project_issuable_information_filter_spec.rb
  - spec/helpers/merge_requests_helper_spec.rb
  - spec/helpers/nav/top_nav_helper_spec.rb
  - spec/helpers/notify_helper_spec.rb
  - spec/lib/banzai/filter/reference_redactor_filter_spec.rb
  - spec/lib/banzai/reference_redactor_spec.rb

See a similar merge request as an example: !81379 (merged)

Edited by Arturo Herrero