Diff changes - Viewed checkbox - disables shortcut keys when focused
Summary
Given I'm inside Merge Request at tab Changes and viewing some files When I use keyboard shortcuts 'j' and 'k' Then it works as it is supposed to work, navigating me between previous and next file.
However... Given I'm inside Merge Request at tab Changes and viewing some files When I click on checkbox "viewed" for some file and after that I use keyboard shortcuts 'j' and 'k' Then it doesn't work as it is supposed to work, navigating me between previous and next file
Because that checkbox is focused and it is blocking any keyboard inputs. (Even '?' doesn't work when it is focused, BUT 'Tab' works and immediately when I lose focus of that checkbox, the shortcuts works again)
Steps to reproduce
- Open some Merge Request
- Navigate to Changes tab
- Try pressing 'j' and 'k', this works
- Click on "Viewed" on any file in those changes
- Try pressing 'j' and 'k', this now DOESN'T work
Example Project
No need, this behavior is at any project merge requests.
What is the current bug behavior?
Blocks keyboard inputs for shortcuts.
What is the expected correct behavior?
That it doesn't block keyboard shortcuts and they normally work.
Relevant logs and/or screenshots
Image just after clicking on "Viewed" and it is being focused:
When focus on checkbox disappears, shortcuts works fine:
Output of checks
This happens on gitlab.com and also on our self-hosted instance:
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:env:info`) (For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true
)(we will only investigate if the tests are passing)