Instance-level DevOps Adoption: Using direct link spoils usage metric
Summary
When user visits instance devops report page without proper license incorrect usage event is sent. DevOps score page is rendered but i_analytics_dev_ops_adoption event is tracked instead of i_analytics_dev_ops_score
Expected behavior
-
i_analytics_dev_ops_adoptionshould be tracked only if the page actually renders. I.e. proper tab is selected + license allows page to be rendered. -
i_analytics_dev_ops_scoreshould be tracked if license doesn't allow DevopsAdoption ORdevops-scoretab is selected.
Actual behavior
i_analytics_dev_ops_adoption is tracked when tab param is one of DevOps Adoption tabs regardless of license.
Technical details
https://gitlab.com/gitlab-org/gitlab/blob/master/ee/app/controllers/ee/admin/dev_ops_report_controller.rb should be aware of license check when sending tracking event.
Edited by Dan Jensen