Follow-up from "WIP: Fix `/readiness` to include health of Puma/Unicorn and blackout period"
The following discussion from !17962 (merged) should be addressed:
-
@andrewn started a discussion: (+4 comments) On monkey-patching Puma (and Unicorn below).. It’s not ideal but,
On one hand,
- This extension point is not part of a published API, therefore could accidentally break with any minor version bump to the puma gem.
On the other hand,
- The method has been around since 2013 and unchanged since 2017
- You’ve added some safety in the method check
- We control the puma version being used
- There are no hooks to employ for this
So, presuming we thoroughly test this to ensure that doesn't break on puma version upgrades it should be fine.