Geo: Update Geo Status Page URL to `admin/geo/sites`
What/Why
We are currently in the works of "rebranding" Geo Nodes => Geo Sites. As the UI is beginning to change we still have to consider the path to get to the Geo Status Page.
Url | |
---|---|
Current | /admin/geo/nodes |
Proposed | /admin/geo/sites |
Concerns
I am worried about any replication or backend expectations of this route that could break when we change it. So, I wanted to engage the @geo-team Backend team members for any insight on challenges that could be related to doing this. My Rails knowledge is still novice but from what I can tell in the route definitions we may need to rename the NodesController
=> SitesController
for the Rails routing to then work as proposed.
Proposal
Route definitions: https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/config/routes/admin.rb#L45-76
Refactor what is needed to allow for the status route to be updated to admin/geo/sites
. Also a redirect then added to redirect from the old route to the new route for a set amount of milestones.
Suggested Approach
- Rename backend view folders from
nodes
=>sites
- Rename
NodesController
=>SitesController
- Update
/
route definition to =>get '/' => 'sites#index'
- Update controller route definitions to =>
resources :sites, only: [:index, :create, :new, :edit, :update]
- Create a redirect from
/admin/geo/nodes
=>/admin/geo/sites
for a few milestones