Metrics with no definitions are not added to service ping

Summary

Metrics with no metric definition yaml file are not added to service ping payload for instances with a license

Metrics affected

The metrics we identified we are not sending in service ping payload are:

  • duration_s
  • geo_node_usage
  • failures
  • group_saml & other providers like twitter, salesforce etc that comes under the key user_auth_by_provider

Note: We will update the list as we identify other metrics

Notes

How can we make sure we are sending all metrics?

In this issue we should

  • Add metrics definitions for known missing yaml files
  • Check the other metrics which are dynamically added, check if any of the metric definitions is missing
  • Check service ping payload before filtering with service ping after filtering. This was done here

cc @amandarueda @nicolasdular

Edited by Alina Mihaila