Persist SAST Configuration feedback alert on dismissal
Context
This is a follow-up issue from !69747 (comment 671316223)
See discussion
@pgascouvaillancourt: seeing this makes me realize that the UX for dismissing the feedback alert isn't great as it will always come back when you visit the page again. We should probably persist the dismissal in the local storage or in the DB
🤔 On the other hand, those feedback alerts aren't meant to stay in the codebase for years either, so it's probably okay to keep them as simple as possible. Perhaps we should make them non-dismissible then🤷
@mfangman: If I understand it correctly, the dismissal of an alert should be permanent unless an action or system event reproduces it. I've called out the relevant points below for your reference. Here's a link to the full page for context as well. With that in mind, I'd propose that we could either 1) remove the dismissal action altogether (if we deemed that the alert is important enough to warrant it), or 2) update the component's behavior to follow Pajama's guidelines.
@beckalippert: Good point! I want to follow Pajamas' guidelines, and also lean towards your option 2 to make it dismissed at the level of local storage or in the DB. After all, we are GitLab where everyone can contribute, so users can always open up an issue if they have feedback. I'd encourage follow-up user research, anyway, if this page has any significant changes in the future (although I don't believe much is on the roadmap in that regard, aside from potentially adding custom rules - but even this wouldn't happen until after the SaaS Reliability Initiative is complete).
Proposal
Persist alert dismissal at the level of local storage or DB.
Screenshot
Implementation Plan
-
Add LocalStorageSync
toee/app/assets/javascripts/security_configuration/components/configuration_page_layout.vue
-
Update specs