Container image list is not refreshed after deletion
Summary
When I press "Delete selected tags" in the container registry of a project, the selected images are deleted, but the UI is not reloaded. It should refresh the list afterwards so that the items I just deleted are no longer displayed.
Steps to reproduce
Go to a project in the Container Registry, select one or more images and press "Delete selected tags".
What is the current bug behavior?
UI still lists the deleted images.
What is the expected correct behavior?
UI should refresh the list of current images.
Designs
- Show closed items
Relates to
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#4458 (closed)
mentioned in issue gitlab-org/quality/triage-reports#4458 (closed)
- Kyle Wiebers added UX featureenhancement grouppackage registry labels
added UX featureenhancement grouppackage registry labels
- 🤖 GitLab Bot 🤖 added typefeature label
added typefeature label
- Kyle Wiebers added Category:Container Registry label
added Category:Container Registry label
1Collapse replies - Maintainer
Just reproduced this, it seems to be a small bug in our frontend cache.
this issue has a frontend-weight1
- Maintainer
Setting label(s) devopspackage sectionops based on ~"group::package".
- 🤖 GitLab Bot 🤖 added devopspackage sectionops labels
added devopspackage sectionops labels
- 🤖 GitLab Bot 🤖 added [deprecated] Accepting merge requests label
added [deprecated] Accepting merge requests label
added frontend-weight1 workflowready for development labels
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#4601 (closed)
mentioned in issue gitlab-org/quality/triage-reports#4601 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#4668 (closed)
mentioned in issue gitlab-org/quality/triage-reports#4668 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#4761 (closed)
mentioned in issue gitlab-org/quality/triage-reports#4761 (closed)
- Tim Rizzi mentioned in issue #341294 (closed)
mentioned in issue #341294 (closed)
- Nicolò Maria Mezzopera set weight to 1
set weight to 1
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#4851 (closed)
mentioned in issue gitlab-org/quality/triage-reports#4851 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#4940 (closed)
mentioned in issue gitlab-org/quality/triage-reports#4940 (closed)
- Katie Macoy added severity4 label
added severity4 label
- Tim Rizzi added [deprecated] good for new contributors label
added [deprecated] good for new contributors label
I would like to work on this issue but I would love to take some guidance. This will be the my first attempt to contribute an open-source project. Could you help to figure out where in the code I should go and make changes?
Collapse replies - Maintainer
@TunaOzk The component responsible to delete an image is: https://gitlab.com/gitlab-org/gitlab/blob/0de2278e788ceb0ca3a797a8c0ee339013d38093/app/assets/javascripts/packages_and_registries/container_registry/explorer/components/delete_image.vue
What needs to be done here is to:
- Check if we can update the apollo cache to remove the entry
- If not execute a refresh of the list
Since this is a delete operation probably
2
is the way to go, but I would first check if number1
is viable
- Katie Macoy added Seeking community contributions label
added Seeking community contributions label
- Maintainer
@katiemacoy thanks for adding the Seeking community contributions label!
This issue's description does not seem to have a section for "Implementation Guide". Please consider adding one, because it makes a big difference for contributors. This section can be brief but must have clear technical guidance, like:
- Hints on lines of code which may need changing
- Hints on similar code/patterns that can be leveraged
- Suggestions for test coverage
- Ideas for breaking up the merge requests into iterative chunks
- Contributor
I would like to take this issue. Could someone assign it to me?
Collapse replies - Maintainer
Hello @marshalmiller
Are you planning to working on this? Thanks!
Edited by Rahul Chanila - Contributor
I'm afraid I have not had time. I will give it up if someone else can pick it up.
...
On Mon, Mar 6, 2023 at 9:06 PM Rahul Chanila (@rchanila) < gitlab@mg.gitlab.com> wrote:
Rahul Chanila https://gitlab.com/rchanila commented on a discussion #339566 (comment 1303195715):
Hello @marshalmiller https://gitlab.com/marshalmiller
Are you still planning to working on this? Thanks!
— Reply to this email directly or view it on GitLab #339566 (comment 1303195715). You're receiving this email because you have been mentioned on gitlab.com. Unsubscribe https://gitlab.com/-/sent_notifications/REDACTED/unsubscribe from this thread · Manage all notifications https://gitlab.com/-/profile/notifications · Help https://gitlab.com/help
- Maintainer
Thanks for reaching back, happy to schedule this for our next milestone so I can pick it up.
I will unassign you.
Edited by Rahul Chanila
@marshalmiller Done!
- Tim Rizzi assigned to @marshalmiller
assigned to @marshalmiller
- Maintainer
Thanks for working on this @marshalmiller! We've removed the Seeking community contributions label to avoid having multiple people working on the same issue.
Hi! I faced with the same issue.
The video is below. https://youtu.be/mWh3ytA9Xho
I'd like to mention that I see the cache issues not only in Container Registry module, but also everywhere in gitlab.com
- Katie Macoy mentioned in issue #368535 (closed)
mentioned in issue #368535 (closed)
- 🤖 GitLab Bot 🤖 added groupcontainer registry label and removed grouppackage registry label
added groupcontainer registry label and removed grouppackage registry label
- Rayana Verissimo added typebug label and removed typefeature label
added typebug label and removed typefeature label
- 🤖 GitLab Bot 🤖 removed featureenhancement label
removed featureenhancement label
- Rayana Verissimo added bugfunctional label
added bugfunctional label
- 🤖 GitLab Bot 🤖 added bugux + 1 deleted label and removed bugfunctional label
added bugux + 1 deleted label and removed bugfunctional label
- Marcel van Remmerden added 1 deleted label
added 1 deleted label
- Rahul Chanila marked this issue as related to #216755
marked this issue as related to #216755
- Rahul Chanila mentioned in issue #371467 (closed)
mentioned in issue #371467 (closed)
- Rahul Chanila marked this issue as related to #371467 (closed)
marked this issue as related to #371467 (closed)
- Rahul Chanila changed milestone to %15.11
changed milestone to %15.11
- Rahul Chanila added Deliverable Package:P1 labels
added Deliverable Package:P1 labels
- Rahul Chanila unassigned @marshalmiller
unassigned @marshalmiller
- Rahul Chanila mentioned in issue #386882 (closed)
mentioned in issue #386882 (closed)
- Developer
cc @rchanila Adding Package P2
1 - Jackie Porter added Package:P2 label
added Package:P2 label
- Crystal Poole removed Package:P1 label
removed Package:P1 label
- Crystal Poole removed Deliverable label
removed Deliverable label
- Rahul Chanila assigned to @rchanila
assigned to @rchanila
- Rahul Chanila mentioned in merge request !114421 (closed)
mentioned in merge request !114421 (closed)
- Rahul Chanila removed 1 deleted label
removed 1 deleted label
- Rahul Chanila removed [deprecated] good for new contributors label
removed [deprecated] good for new contributors label
- Rahul Chanila added workflowin dev label and removed workflowready for development label
added workflowin dev label and removed workflowready for development label
- Rahul Chanila marked this issue as related to #349510 (closed)
marked this issue as related to #349510 (closed)
- Maintainer
Async update
- Status: workflowin dev
- Complete:
20%
- Confidence:
20%
- Notes:
- I noticed the same issue on the container registry list page, so opened a draft MR to fix it.
- To fix the issue on container registry tags list(details) page, found out that Fix number of tags label after deleting tags (!102940 - merged) to fix Number of tags label does not update after dele... (#349510 - closed) in %15.6 fixed this as well. However, it introduced a Container Registry Search not working interacti... (#384042 - closed) resulting in Fix the Container Registry tag filter (!107433 - merged) which did fix the issue. While the total count is updated, it has re-introduced the issue where the tags list are not refreshed upon deletion.
FYI @crystalpoole
- cc @svistas since I believe Test Container Registry search and sorting on t... (#345136) could help prevent such regression.
- Next steps: investigate way to fix both issues, need to debug apollo cache type policies
- MR
Edited by Rahul Chanila - Jackie Porter added priority4 label
added priority4 label
- Sofia Vistas mentioned in issue #345136
mentioned in issue #345136
- Maintainer
Async update
- Status: workflowin dev
- Complete:
50%
- Confidence:
70%
- Notes:
- The fix involves moving the delete tag mutation to the tags list component & refetching the query.
- I also found a way to keep the current page when tags are deleted instead of refetching the first page always.
- Added feature tests to confirm ~bug is fixed.
- Pending: Refactor & add tests.
- Considering
, bumping weight to 2
- MRs
- Draft: Refetch container image list upon deletion (!114421 - closed) - In draft
- ...TBD
- Rahul Chanila added frontend-weight2 label and removed frontend-weight1 label
added frontend-weight2 label and removed frontend-weight1 label
- Rahul Chanila set weight to 2
set weight to 2
- Rahul Chanila mentioned in merge request !115634 (merged)
mentioned in merge request !115634 (merged)
- Rahul Chanila added bugfunctional frontend labels and removed UX bugux labels
added bugfunctional frontend labels and removed UX bugux labels
- Maintainer
Async update
- Status: workflowin review
- Notes:
- Opened MR Refetch container image tags list after deletion (!115634 - merged) which fixes issue.
-
MR does not attempt to keep current page when tags are deleted. - Will pick Draft: Refetch container image list upon deletion (!114421 - closed) later during the milestone since it fixes refetching the list page
- MRs
1 - Rahul Chanila added workflowin review label and removed workflowin dev label
added workflowin review label and removed workflowin dev label
- Rahul Chanila added workflowverification label and removed workflowin review label
added workflowverification label and removed workflowin review label
- Maintainer
Verified in production, please see screen recording:
- Rahul Chanila closed
closed
- Rahul Chanila added workflowcomplete label and removed workflowverification label
added workflowcomplete label and removed workflowverification label
- Maintainer
@rchanila, the workflow label was automatically updated to workflowcomplete because you closed the issue while in workflowverification.
If this is not the correct label, please update.
To avoid this message, update the workflow label as you close the issue.