Re-name group and project delete "adjourned" and "soft deleted" as "delayed" in code
During the implementation of delayed group and project deletion, we used various terminology in the documentation and in the codebase. We converged on a single set of terms. We use:
-
delayed
instead ofadjourned
orsoft-deleted
: #223013 (closed) -
delete
instead ofremove
: #221100 (closed)
These are already fixed in the documentation. However, we haven't refactored the naming in the codebase. It still uses a mix of those terms, making it difficult to identify the various code parts that belong together to implement a single feature.
List of classes / methods / files that need to be refactored:
AdjournedGroupDeletionWorker
AdjournedProjectsDeletionCronWorker
AdjournedProjectDeletionWorker
Group#adjourned_deletion?
Project#adjourned_deletion?
ApplicationSetting#deletion_adjourned_period
NamespaceSetting#delayed_project_removal
- the feature in
License
is calledadjourned_deletion_for_projects_and_groups
ee/app/views/groups/settings/_adjourned_deletion.html.haml
ee/app/views/admin/application_settings/_default_project_deletion_adjourned_period_setting.html.haml
ee/app/assets/javascripts/projects/project_adjourned_delete_button.js
ee/app/assets/javascripts/projects/components/project_adjourned_delete_button.vue
Edited by Imre Farkas