GitHub Importer - Verify that DB queries do not exceed statement timeout
Follow up from !67150 (comment 652170403)
Okay, that helps. It seems like we don't have an ideal solution here without fundamentally changing how it works. In that sense it seems more acceptable to have a few slow queries only in an extreme case than to make thousands of extra redis calls on every import.
Since this is also behind a feature flag we can always monitor how often we have actually have these types of long-running queries and consider an alternative approach if it's a common issue. We should also make sure we're staying well below the statement timeout (15s), or the import process wouldn't be able to continue. Could you make a follow-up issue to track that and I'll approve?
MR above adds a new alternative way of importing notes which is behind a feature flag, to help ProServ team with customer migrations of extra large projects.
This change however introduces a few db queries that, in extreme situations, can take up to 10 seconds to perform.
ToDo
-
Verify that these queries do not hit statement timeout or if they need further optimisation.
Edited by Haris Delalić