[Feature flag] Disable individual historical vulnerability statistics update
Summary
Feature flag: keep_historical_vulnerability_statistics_always_consistent
As discussed in !68124 (comment 650750189), this code is not necessary and should be removed.
In this instance, a feature flag is being used to remove a feature, rather than add it. We're doing this so we can confirm that there will be no unforeseen impact to the removal of the updates.
Owners
- Team: @gitlab-org/secure/threat-insights-backend-team
- Most appropriate slack channel to reach out to:
#g_secure_threat_insights
- Best individual to reach out to: @minac
- PM: @matt_wilson
Stakeholders
The Rollout Plan
- Disabled by default (i.e.: the feature is removed)
- Validate by looking at security dashboards
- Remove code wrapped around FF and the FF itself.
Testing Groups/Projects/Users
N/A
Expectations
What are we expecting to happen?
The vulnerability trends in the security dashboard widgets are for identifying trends over time so don't need to be available for the current day
What might happen if this goes wrong?
Vulnerability counts in security dashboard are incorrect or out-of-date.
What can we monitor to detect problems with this?
Observe familiar security over the next 1-2 weeks.
Rollout Steps
As per roll-out plan.
Release the feature
After the feature has been deemed stable, the clean up should be done as soon as possible to permanently enable the feature and reduce complexity in the codebase.
-
Create a merge request to remove <feature-flag-name>
feature flag. Ask for review and merge it.-
Remove all references to the feature flag from the codebase. -
Remove the YAML definitions for the feature from the repository. -
Create a changelog entry.
-
-
Ensure that the cleanup MR has been deployed to both production and canary. If the merge request was deployed before the code cutoff, the feature can be officially announced in a release blog post. -
/chatops run auto_deploy status <merge-commit-of-cleanup-mr>
-
-
Close the feature issue to indicate the feature will be released in the current milestone. -
Clean up the feature flag from all environments by running these chatops command in #production
channel:-
/chatops run feature delete <feature-flag-name> --dev
-
/chatops run feature delete <feature-flag-name> --staging
-
/chatops run feature delete <feature-flag-name>
-
-
Close this rollout issue.
Rollback Steps
-
This feature can be disabled by running the following Chatops command:
/chatops run feature set <feature-flag-name> false