Update approvals API for consistency across group and project endpoints
Problem to solve
The frontend team has noted that group approvals deviates from the existing project API. The problem is that users of the approvals API would expect the same attributes and values for both projects & groups.
Settings map from #325620 (closed):
Group Setting | Project Setting |
---|---|
allow_overrides_to_approver_list_per_merge_request | disable_overriding_approvers_per_merge_request |
allow_author_approval | merge_requests_author_approval |
allow_committer_approval | merge_requests_disable_committers_approval |
retain_approvals_on_push | reset_approvals_on_push |
require_password_to_approve | require_password_to_approve |
Proposed solution
Before we launch group approval rules we should unify the approval rules api endpoints. Because the project API is already public it would make the most sense to update the group API to match the project attributes.
The cost of us not updating the group approval API now is that if we decide to do so after launch then we won't be able to until the next API version as it would count as a breaking change.