Follow-up from "GraphQL Vuln Modal: Add solution and report-type"

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

Currently the SolutionCard component (ee/app/assets/javascripts/vue_shared/security_reports/components/solution_card_vuex.vue) contains a top-level condition that makes the component render nothing if there is no content to display.

This prevents the card from rendering an empty div with borders:

Screen_Shot_2021-08-05_at_11.16.17_am

This logic should be moved into the parent components.

Implementation plan

  1. Remove top-level v-if from ee/app/assets/javascripts/vue_shared/security_reports/components/solution_card_vuex.vue
  2. Move the condition to ee/app/assets/javascripts/security_dashboard/components/pipeline/vulnerability_finding_modal.vue and ee/app/assets/javascripts/vue_shared/security_reports/components/modal.vue
  3. Update specs

Note: This is a follow up from !67128 (merged), the relevant discussion can be found here: !67128 (comment 638587486)

Edited by 🤖 GitLab Bot 🤖