Skip to content

Merge request approval icon in MR list view can be misleading

Problem

On first glance, this section says to me "This MR has been approved but still needs one more approval" when it actually means "MR has no approvals; must have at least one"

Screen_Shot_2021-08-05_at_2.04.02_PM

Proposal

  • Should we update the icon to look less "approved"? It might be the check mark that's throwing it off a little
  • Should the wording be updated? 1 left somehow sounds like it has been approved but there's still one left.
  • Should we increase the spacing between each section?
Edited by Annabel Dunstone Gray