Global Search: Remove duplication between Group and Project filter specs
The following discussion from !67187 (merged) should be addressed:
-
@kushalpandya started a discussion: (+3 comments) optional: I wonder if we can combine this test with the one we have for
project_filter.vue
as the test is largely the same, only the action called and data asserted changes depending on the context. The reason why I propose this is because the underlying behaviour of both the dropdowns is the same, only the keys (groups vs. projects) change so having two separately implemented tests is unnecessary repetition. -
@zcuddy continued the discussion: I think that with those spec files being so similar as it is, moving one assertion out into the assumably
app_spec
might be a little confusing why we are being explicit every where else except this particular test. I'd prefer to take a look at this in a follow up focused on potentially generalizing both of those files into the parent rather than just one piece here. I will create a follow up off this thread if that is okay with you🙇