Test Metadata retrieval from GitLab Pages (not artifacts) pulled the Cloudflare page

In https://gitlab.com/gitlab-org/gitlab/-/pipelines/345583939/failures the rspec jobs failed because retrieve-test-metadata pulled the Cloudflare limiting page from https://gitlab-org.gitlab.io/gitlab/knapsack/report-master.json.

You can see a copy of what the retrieved json file was at https://gitlab-org.gitlab.io/-/gitlab/-/jobs/1465734750/artifacts/knapsack/report-master.json but the retrieve-test-metadata job retrieved from the pages URL https://gitlab-org.gitlab.io/gitlab/knapsack/report-master.json.

This caused all rspec jobs to fail when parsing the test knapsack metadata like https://gitlab.com/gitlab-org/gitlab/-/jobs/1465734868

Workaround

  1. Retry the retrieve-test-metadata job: https://gitlab-org.gitlab.io/-/gitlab/-/jobs/1465734750
  2. Confirm the retrieved file in the artifacts is a json file: https://gitlab-org.gitlab.io/-/gitlab/-/jobs/1465734750/artifacts/knapsack/report-master.json
  3. Retry the failed rspec builds

Questions

  • Can this be handled in the retrieve-test-metadata script to retry if the returned file isn't JSON?
  • Does this affect flaky and crystalball files as well?
Edited Aug 25, 2021 by Kyle Wiebers
Assignee Loading
Time tracking Loading