Error linking existing user account to new smart card
Summary
If smart card authentication is enabled and the "Sign-up enabled" box is unchecked, and a smart card is presented with the same email as an existing user, an error will be presented. The correct behavior is that the user should be linked with the existing account and logged in.
Steps to reproduce
- New AWS EC2 instance. T2.Medium / Amazon Linux. Ports 22,80,443,3444 open.
- Set hostname and install GitLab Omnibus using yum (https with let's encrypt)
- Bring up GitLab and set root password.
- Install premium license
- Create a new user. Use the e-mail address programmed onto the smart card.
- Open admin page and uncheck "Sign-up enabled"
- Edit /etc/gitlab/gitlab.rb to add gitlab_rails['smartcard_enabled'] = true gitlab_rails['smartcard_ca_file'] = "/etc/gitlab/ssl/TanukiCA.pem" gitlab_rails['smartcard_client_certificate_required_port'] = 3444
- Upload CA key to /etc/gitlab/ssl/
- gitlab-ctl reconfigure
- Insert smart card and go to login page
- Select "Login with smart card". Select certificate and enter pin
An error message will be presented that says "Failed to signing using smart card authentication" and the user will not be logged in.
Enabling Sign-ups will resolve this issue but may not be desirable for other reasons.
Example Project
Because this bug involves smart card authentication, it can not be recreated on GitLab.com. I have a test server running on AWS that I used to validate the steps to reproduce. Let me know if you would like access.
What is the current bug behavior?
An error message will be presented that says "Failed to signing using smart card authentication" and the user will not be logged in.
What is the expected correct behavior?
The smart card should be linked to the existing user account using e-mail and the appropriate user should be logged in.
Relevant logs and/or screenshots
I recreated the error and checked the logs but did not see anything that appeared to be relevant.
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Proxy: no Current User: git Using RVM: no Ruby Version: 2.6.3p62 Gem Version: 2.7.9 Bundler Version:1.17.3 Rake Version: 12.3.2 Redis Version: 3.2.12 Git Version: 2.22.0 Sidekiq Version:5.2.7 Go Version: unknownGitLab information Version: 12.3.5-ee Revision: 9dbaa740018 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: PostgreSQL DB Version: 10.9 URL: https://testgl.fernlab.net HTTP Clone URL: https://testgl.fernlab.net/some-group/some-project.git SSH Clone URL: git@testgl.fernlab.net:some-group/some-project.git Elasticsearch: no Geo: no Using LDAP: no Using Omniauth: yes Omniauth Providers:
GitLab Shell Version: 10.0.0 Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab subtasks ...Checking GitLab Shell ...
GitLab Shell: ... GitLab Shell version >= 10.0.0 ? ... OK (10.0.0) Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Redis available via internal API: OK
gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Gitaly ...
Gitaly: ... default ... OK
Checking Gitaly ... Finished
Checking Sidekiq ...
Sidekiq: ... Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Incoming Email ...
Incoming Email: ... Reply by email is disabled in config/gitlab.yml
Checking Incoming Email ... Finished
Checking LDAP ...
LDAP: ... LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab App ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... can't check, you have no projects Redis version >= 2.8.0? ... yes Ruby version >= 2.5.3 ? ... yes (2.6.3) Git version >= 2.22.0 ? ... yes (2.22.0) Git user has default SSH configuration? ... yes Active users: ... 3 Is authorized keys file accessible? ... yes Elasticsearch version 5.6 - 6.x? ... skipped (elasticsearch is disabled)
Checking GitLab App ... Finished
Checking GitLab subtasks ... Finished