Project scope sorted_by_similarity_desc has an unused param
Summary
Found while working on !64342 (merged)
There is a scope in the Project model named sorted_by_similarity_desc that has an unused parameter include_in_select
What is the current bug behavior?
include_in_select should be passed as an input to Gitlab::Pagination::Keyset::ColumnOrderDefinition.new( in the add_to_projections attribute.
What is the expected correct behavior?
The add_to_projections is set to true and the include_in_select parameter is unused
Possible fixes
The parameter should be passed into add_to_projections. However, the uses of it currently assume the parameter to be true so all instances where it used should be updated to pass in include_in_select: true when using the scope.
Edited by 🤖 GitLab Bot 🤖