Follow-up from "Add descendantGroups field to Group type"
The following discussions from !65255 (merged) should be addressed:
-
@tigerwnz started a discussion: Not blocking: Should we also update the regular API to use this new logic?
-
@acroitor started a discussion: Also it seems we can refactor these 2 lines https://gitlab.com/gitlab-org/gitlab/blob/master/lib/api/groups.rb#L51-L53 to be passed in as params to
GroupFinder
so we'd just callgroups = GroupsFinder.new(current_user, find_params).execute
, right ? This can go into a follow-up as well if need be. -
@acroitor started a discussion: iterating through this collection lead me think we iterate over each group and applying filters on each group, which is weird, but then I realized this is a
collection
ofcollections
. I wonder if this would make it easier to understand, but I did not really test it for bugs or performance, and I think it can be moved to a follow-up even if we wanted to do it, but I'll still post it here now that I have it😸