Skip to content
GitLab
Next
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 44,761
    • Issues 44,761
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1,330
    • Merge requests 1,330
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLabGitLab
  • Issues
  • #335789
Closed
Open
Issue created Jul 12, 2021 by Thiago Figueiró@thiagocsfDeveloper0 of 4 checklist items completed0/4 checklist items

Validate security report artifact against vendored versions

Why are we doing this work

We want to clearly communicate to users whenever a security report artifact does not validate against a supported schema or has other parsing errors.

In order to do this, all supported schemas will be vendored into the GitLab rails application, as discussed as part of #322681 (closed).

Relevant links

  • Wording for alert

Non-functional requirements

  • Documentation: update accordingly https://docs.gitlab.com/ee/development/integrations/secure.html#enable-report-validation
  • Feature flag: enforce_security_report_validation this needs a FF so we can give analyzer teams a chance to comply with the schemas before breaking ingestion
  • Performance:
  • Testing:

Implementation plan

  • backend Create enforce_security_report_validation feature flag definition
  • backend Adjust ee/app/models/ee/ci/build.rb so that validate_schema? returns true if enforce_security_report_validation is enabled
  • backend Adjust lib/gitlab/ci/parsers/security/validators/schema_validator.rb so it adds a warning/error if the schema used is deprecated/not found
  • backend Adjust specs
Edited Mar 15, 2022 by Michał Zając
Assignee
Assign to
Time tracking