Emoji-only commit messages are not clickable in 'Commits' view

Summary

When a commit message only consists of emojis and no alphanumeric characters, it does not turn into a clickable link in the "Repository" -> "Commits" view.

Steps to reproduce

  • Make a commit with a commit message consisting only of emojis
  • Push
  • Go to the "Commits" page and click on the commit, as if you would want to view the commit diff etc.

Example Project

https://gitlab.com/colorchestra/emoji-commit-test/commits/master

What is the current bug behavior?

The commit message is not a clickable link. There is no way to get to the commit view, other than manipulating the URL directly and pasting the commit hash into the address bar

What is the expected correct behavior?

The commit message becomes a clickable link, like a commit message containing text

Relevant logs and/or screenshots

(Paste any relevant logs - please use code blocks (```) to format console output, logs, and code as it's tough to read otherwise.)

Output of checks

This bug happens on GitLab.com (and also on our instance running Gitlab CE 12.3.4)

Results of GitLab environment info

Can't imagine this info is really necessary, can provide it upon request though

Expand for output related to GitLab environment info

(For installations with omnibus-gitlab package run and paste the output of: sudo gitlab-rake gitlab:env:info)

(For installations from source run and paste the output of: sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production)

Results of GitLab application Check

Can't imagine this info is really necessary, can provide it upon request though

Expand for output related to the GitLab application check

(For installations with omnibus-gitlab package run and paste the output of: sudo gitlab-rake gitlab:check SANITIZE=true)

(For installations from source run and paste the output of: sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)

(we will only investigate if the tests are passing)

Possible fixes

(If you can, link to the line of code that might be responsible for the problem)

Edited Oct 07, 2019 by Marvin
Assignee Loading
Time tracking Loading