Skip to content

VSA stage table data not clearing when error occurs

Summary

In the group level VSA, when a query timeout occurs the backend returns an error Too much data. This error should be presented to the user in the VSA stage table, but it appears that when moving between stages and data from a previous stage is in the vuex store, then the error message is not displayed.

Steps to reproduce

  1. Go to the development stage: https://gitlab.com/groups/gitlab-org/-/analytics/value_stream_analytics?created_af[…]ue_stream_id=4&stage_id=93&sort=end_event&direction=desc&page=1
  2. See the records are loading
  3. Go to the test stage
  4. After 15s, we see the records table is loaded but the response returns an error message only

Example Project

What is the current bug behavior?

Data from a different stage of the value stream is displayed in the stage table

What is the expected correct behavior?

  • The error message is displayed
  • Stage data is cleared

Relevant logs and/or screenshots

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info

(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:env:info`)

(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)

Results of GitLab application Check

Expand for output related to the GitLab application check

(For installations with omnibus-gitlab package run and paste the output of: sudo gitlab-rake gitlab:check SANITIZE=true)

(For installations from source run and paste the output of: sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)

(we will only investigate if the tests are passing)

Possible fixes